[Lustre-devel] moving obd_fail_check to libcfs

Robert Read rread at sun.com
Mon Feb 23 00:11:12 PST 2009

I don't think libcfs currently initializes any proc entries, so it's  
not clear how you will set obd_fail_loc.  In theory libcfs should just  
thin library of porting primitives, and things like logging and  
fail_check should be in a layer just above libcfs which could have a  
management interface.    So far we've just put some extra low-level  
functionality into libcfs, but at some point it should be refactored.  
I think when we need to add initialization code and an interface is  
that point.


On Feb 22, 2009, at 8:15 PM, Nic Henke wrote:

> Would there be any objection to a patch that'd move the current
> obdclass-centric obd_fail_check and friends to libcfs ? I'd like to be
> able to use the same logic inside LNET and our new LND without
> replicating the code.
> I'm thinking it would need to be renamed to CFS_FAIL_CHECK as well.
> Thoughts or suggestions?
> Nic
> _______________________________________________
> Lustre-devel mailing list
> Lustre-devel at lists.lustre.org
> http://lists.lustre.org/mailman/listinfo/lustre-devel

More information about the lustre-devel mailing list