[lustre-devel] [PATCH 21/40] staging: lustre: improve LNet clean up code and API

Dan Carpenter dan.carpenter at oracle.com
Wed Dec 2 04:59:45 PST 2015

Actually we're going to have to redo so much code that it's not worth it
for me to review the rest of these patches.  Please just look over
everything again:

 BAD:	return -1;
GOOD:	return -EINVAL;

 BAD:  failed0:
GOOD:  free_something:

 BAD:	if (rc != 0)
GOOD:	if (rc)

Do one thing per patch.
Do not introduce a bug and then fix it in a later patch.
Check ioc_len more carefully.
Don't make the code look ugly just to please checkpatch.pl.
Do error handling not success handling.
Try to avoid indenting a far to the right.

dan carpenter

More information about the lustre-devel mailing list