[lustre-devel] [PATCH 21/40] staging: lustre: improve LNet clean up code and API

Alexander Zarochentsev alexander.zarochentsev at seagate.com
Wed Dec 2 05:20:59 PST 2015


On Wed, Dec 2, 2015 at 3:59 PM, Dan Carpenter <dan.carpenter at oracle.com> wrote:
> Actually we're going to have to redo so much code that it's not worth it
> for me to review the rest of these patches.  Please just look over
> everything again:
>  BAD:   return -1;
> GOOD:   return -EINVAL;
>  BAD:  failed0:
> GOOD:  free_something:
>  BAD:   if (rc != 0)
> GOOD:   if (rc)

The latest suggestion is not correct,
from http://wiki.lustre.org/Lustre_Coding_Guidelines :
Conditional boolean (if (expr)), scalar (if (val != 0)) and pointer
(if (ptr != NULL)) expressions should be written consistently.


Alexander Zarochentsev
Seagate Technology, LLC

More information about the lustre-devel mailing list