[lustre-devel] staging: lustre: Delete unnecessary goto statements in six functions

SF Markus Elfring elfring at users.sourceforge.net
Tue Dec 15 10:26:57 PST 2015


> 	rc = mdc_queue_wait(req);
> 	goto out;
> out:
> 	ptlrpc_req_finished(req);
> 	return rc;
> }
> ---------------------
>
> I think if the last goto out; is to be removed,
> then it should be replaced by a blank line.
>
> It separates the last operation block from the return.

Would you like to point a very specific coding style issue out?
How often should jump labels preceded with blank lines?

Regards,
Markus


More information about the lustre-devel mailing list