[lustre-devel] staging: lustre: Delete unnecessary goto statements in six functions
joe at perches.com
Tue Dec 15 10:34:11 PST 2015
On Tue, 2015-12-15 at 19:26 +0100, SF Markus Elfring wrote:
> > rc = mdc_queue_wait(req);
> > goto out;
> > out:
> > ptlrpc_req_finished(req);
> > return rc;
> > }
> > ---------------------
> > I think if the last goto out; is to be removed,
> > then it should be replaced by a blank line.
> > It separates the last operation block from the return.
> Would you like to point a very specific coding style issue out?
Other than using vertical separation can help readability?
I think there should _not_ be a hardened rule.
Style is just a guide. Do what you think appropriate.
> How often should jump labels preceded with blank lines?
When other nearby blocks are also separated by blank lines.
Localized consistency can be useful.
Inconsistency can make code harder to follow/predict.
More information about the lustre-devel