[lustre-devel] [PATCH] staging: lustre: check result of register_shrinker

Dan Carpenter dan.carpenter at oracle.com
Mon Dec 4 00:35:00 PST 2017


On Sun, Dec 03, 2017 at 12:47:03AM +0000, Dilger, Andreas wrote:
> The preferred way to handle this would be:
> 
> 	rc = ldlm_pools_thread_start();
> 	if (rc)
> 		goto out;
> 
> 	rc = register_shrinker(&ldlm_pools_cli_shrinker);
> 	if (rc)
> 		goto out_pools;
> 
> 	return 0;
> 
> out_pools:
> 	ldlm_pools_thread_stop();
> out:
> 	goto out;
> }

I so badly hate "out" as a label name...  But yours made me laugh.

regards,
dan carpenter



More information about the lustre-devel mailing list