[lustre-devel] [PATCH] staging: lustre: check result of register_shrinker

Dan Carpenter dan.carpenter at oracle.com
Mon Dec 4 00:40:18 PST 2017

On Sun, Dec 03, 2017 at 07:59:07PM +0300, ak wrote:
> Thank you for your extensive comments.
> I've also thought about adding more protection into unregister_shrinker(),
> but not sure how to properly organize the patch set, because there will be
> three patches:
>     * change in mm/vmscan that adds protection and sanitizer.
>     * fixed change for Lustre driver
>     * there also two explicit usages of shrinker->nr_deferred in drivers -
>        good idea to fix too.
> All patches have different lists of maintainers, and second and third depend
> on first one. And I don't like to send them separately.
> So, I'm going to at least prepend this patch with mm/vmscan one.

Fix the style for the Lustre patch and resend.  Then patch
unregister_shrinker().  Then remove the checks.

The unregister_shrinker() changes seem like a good idea, but I haven't
really looked at it.  It might be more involved than it seems.

dan carpenter

More information about the lustre-devel mailing list