[lustre-devel] [PATCH] staging: lustre: lnet: specify address space

Dan Carpenter dan.carpenter at oracle.com
Wed May 17 02:34:18 PDT 2017


On Tue, May 16, 2017 at 10:56:10PM +0200, Paolo Cretaro wrote:
> Fix warning issued by sparse:
> incorrect type in assignment (different address spaces).
> 
> Signed-off-by: Paolo Cretaro <melko at frugalware.org>
> ---
>  drivers/staging/lustre/lnet/lnet/lib-socket.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/staging/lustre/lnet/lnet/lib-socket.c b/drivers/staging/lustre/lnet/lnet/lib-socket.c
> index 9fca8d225ee0..e5e5213b4da0 100644
> --- a/drivers/staging/lustre/lnet/lnet/lib-socket.c
> +++ b/drivers/staging/lustre/lnet/lnet/lib-socket.c
> @@ -181,7 +181,7 @@ lnet_ipif_enumerate(char ***namesp)
>  			goto out0;
>  		}
>  
> -		ifc.ifc_buf = (char *)ifr;
> +		ifc.ifc_buf = (char __user *)ifr;

But it's not a __user pointer so this is wrong.  You have deleted a
valuable warning message which is there to inform us about important
bugs.

regards,
dan carpenter



More information about the lustre-devel mailing list