[lustre-devel] testing lustre

[NeilBrown]

On Thu, Feb 08 2018, Благодаренко Артём wrote:

> Hello NeilBrown,
>
> Symbol “:” is added to name for targets which have never been registered. tunefs and mount use this symbol to
> set LDD_F_VIRGIN flag in ldd.
>
> Here is code from lustre/utils/mkfs_lustre.c (executed in tunefs)
>
>  /* svname of the form lustre:OST1234 means never registered */
>         ret = strlen(ldd->ldd_svname);
>         if (ldd->ldd_svname[ret - 8] == ':') {
>                 ldd->ldd_svname[ret - 8] = '-';
>                 ldd->ldd_flags |= LDD_F_VIRGIN;
>
> And 
>
> lustre/utils/mount_lustre.c
>
> /* svname of the form lustre:OST1234 means never registered */
>         rc = strlen(ldd->ldd_svname);
>         if (strcmp(ldd->ldd_svname, "MGS") != 0) {
>                 if (rc < 8) {
>                         fprintf(stderr, "%s: invalid name '%s'\n",
>                                 progname, ldd->ldd_svname);
>                         return EINVAL;
>                 } else if (ldd->ldd_svname[rc - 8] == ':') {
>                         ldd->ldd_svname[rc - 8] = '-';
>                         ldd->ldd_flags |= LDD_F_VIRGIN;
>
> So I believe the test expects freshly created target.

Thanks for the reply.  This is helpful, but there is still something
missing in my understanding.

At what stage does a filesystem transition from "VIRGIN" to "not
VIRGIN"??
When does the ":" get replaced by a "-" in the on-disk volume name?
What, exactly, does it mean to be "registered" ?

I cannot find anywhere in the code that would write out a new label, or
that would call e2label or tune2fs to do it.

Thanks,
NeilBrown
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 832 bytes
Desc: not available
URL: <http://lists.lustre.org/pipermail/lustre-devel-lustre.org/attachments/20180209/4052ae67/attachment.sig>