[lustre-devel] testing lustre

[Благодаренко Артём]

Hello NeilBrown,

Symbol “:” is added to name for targets which have never been registered. tunefs and mount use this symbol to
set LDD_F_VIRGIN flag in ldd.

Here is code from lustre/utils/mkfs_lustre.c (executed in tunefs)

 /* svname of the form lustre:OST1234 means never registered */
        ret = strlen(ldd->ldd_svname);
        if (ldd->ldd_svname[ret - 8] == ':') {
                ldd->ldd_svname[ret - 8] = '-';
                ldd->ldd_flags |= LDD_F_VIRGIN;

And 

lustre/utils/mount_lustre.c

/* svname of the form lustre:OST1234 means never registered */
        rc = strlen(ldd->ldd_svname);
        if (strcmp(ldd->ldd_svname, "MGS") != 0) {
                if (rc < 8) {
                        fprintf(stderr, "%s: invalid name '%s'\n",
                                progname, ldd->ldd_svname);
                        return EINVAL;
                } else if (ldd->ldd_svname[rc - 8] == ':') {
                        ldd->ldd_svname[rc - 8] = '-';
                        ldd->ldd_flags |= LDD_F_VIRGIN;

So I believe the test expects freshly created target.

Best regards,
Artem Blagodarenko.

> On 8 Feb 2018, at 00:31, NeilBrown <neilb at suse.com> wrote:
> 
> 
> Hi,
> I've set up a little virtual cluster to run the sanity tests.
> One problem I have is that the test harness expects that after it
> creates a filesystem, the label (reported by e2label) will
> spontaneously change from e.g. "lustre:MDT-0000" to "lustre-MDT-0000"
> and that doesn't happen for me.
> If I go and change the label manually while the test is waiting,
> then the test continues and appears to run correctly.
> 
> Can anyone tell me what this name change in meant to indicate, when
> where in the code it is expected to happen?
> 
> Thanks,
> NeilBrown
> _______________________________________________
> lustre-devel mailing list
> lustre-devel at lists.lustre.org
> http://lists.lustre.org/listinfo.cgi/lustre-devel-lustre.org