[lustre-devel] [PATCH] staging: lustre: lnet: return of an error code should be negative

James Simmons jsimmons at infradead.org
Sun Feb 11 13:39:05 PST 2018


> Return value of error codes should typically be negative.
> Issue reported by checkpatch.pl
>

Reviewed-by: James Simmons <jsimmons at infradead.org>
 
> Signed-off-by: Sumit Pundir <pundirsumit11 at gmail.com>
> ---
>  drivers/staging/lustre/lnet/selftest/framework.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/staging/lustre/lnet/selftest/framework.c b/drivers/staging/lustre/lnet/selftest/framework.c
> index c7697f6..0ca1e3a 100644
> --- a/drivers/staging/lustre/lnet/selftest/framework.c
> +++ b/drivers/staging/lustre/lnet/selftest/framework.c
> @@ -187,7 +187,7 @@ sfw_del_session_timer(void)
>  		return 0;
>  	}
>  
> -	return EBUSY; /* racing with sfw_session_expired() */
> +	return -EBUSY; /* racing with sfw_session_expired() */
>  }
>  
>  static void
> -- 
> 2.7.4
> 
> 


More information about the lustre-devel mailing list